Skip to content

Changes DpaHandler2 to own the channel resource.

MelvinWM requested to merge github/fork/MelvinWM/master into master

This change ensures that if users (when cleaning up their usage of 'clibdpa') only delete DpaHandler2, that the IChannel resource will also be cleaned up. This could for instance happen when they restart a part of their system that uses IQRF and clibdpa.

However, if there are users that also clean up the IChannel resource directly, this change might cause bugs and errors for them. This is basically a change of the interface for using DpaHandler2 AFAICT (namely who owns the given resources and has the responsibility for cleaning them up), so it may make sense to reject the pull request.

It seems to me that it may make sense to make this change, since it partially fits with the IChannel resource not being cleaned up directly in the example, and partially that I could imagine that an instance of the IChannel resource is not meant to be reused across multiple DpaHandler2 instances, though I could well be wrong about this latter part.

Testing performed

Only a small amount, ran a program with the change and saw the resources being cleaned up. No unit testing.

Merge request reports

Loading